ANDROID-16934 -- (II) Remove databinding related code #479

dhonti-axpe · 2026-01-04T20:03:01Z

🎟️ Jira ticket

🥅 What's the goal?

Global task: Remove Databinding from Mistica in library module and the corresponding components.

This PR is a part of this three:

After all these PRs are merged, a final one will be created to remove the Data Binding feature from the build.gradle file.

🚧 How do we do it?

Remove BindingMethods, InverseBindingMethod and BindingAdapters methods and update corresponding README files from next components:
* LoaderrorFeedbackView
* HeaderView
* HightlightedCardView
* CheckBoxInput
* Input
* TextInput

☑️ Checks

I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
Tested with dark mode.
Tested with API 24.
Only affects Android side.
Accessibility considerations.

🧪 How can I test this?

As is mentioned in the corresponding ANDROID-16934 ticket, is tested in the "android-messenger" client project that the total PR changes exposed in #476 works correctly.

…"LoadErrorFeedabackView" component and update corresponding README file.

…ck/screen" component

… "HeaderView" component and update corresponding README file

… "HighlightedCardView" component and update its corresponding README file.

… "Input", "TextInput" and expose some attributes also from "CheckBoxInput" components, updating their corresponding README files

github-actions · 2026-01-04T20:10:21Z

[Firebase] 📱 New catalog for testing generated:
Download from Firebase
Download from App Tester

…tInput" component

github-actions · 2026-01-04T20:26:34Z

[Firebase] 📱 New catalog for testing generated:
Download from Firebase
Download from App Tester

Copilot

Pull request overview

This PR removes Android Data Binding infrastructure from six components in the library module: LoadErrorFeedbackView, HeaderView, HighlightedCardView, CheckBoxInput, Input, and TextInput. The changes eliminate BindingMethods, InverseBindingMethods, and BindingAdapter annotations while updating documentation to reflect that these components no longer support data binding.

Changes:

Removed data binding annotations and adapter methods from input components (TextInput, Input, CheckBoxInput) and view components (LoadErrorFeedbackView, HeaderView, HighlightedCardView)
Added wrapper methods in CheckBoxInput and HeaderView to maintain backward compatibility with existing attribute names
Updated README files to clarify that components support attribute-based configuration only, not data binding

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
library/src/main/java/com/telefonica/mistica/input/TextInput.kt	Removed data binding imports, annotations, and text watcher adapter method
library/src/main/java/com/telefonica/mistica/input/README.md	Updated documentation to remove data binding references and added note about standard View implementation
library/src/main/java/com/telefonica/mistica/input/Input.kt	Removed data binding imports and BindingMethods annotation for base Input class
library/src/main/java/com/telefonica/mistica/input/CheckBoxInput.kt	Removed data binding annotations and check watcher adapter; added wrapper methods for attribute compatibility
library/src/main/java/com/telefonica/mistica/highlightedcard/README.md	Updated documentation to remove data binding reference
library/src/main/java/com/telefonica/mistica/highlightedcard/HighlightedCardView.kt	Removed data binding imports and BindingMethods annotation; reordered import statements
library/src/main/java/com/telefonica/mistica/header/README.md	Updated documentation to remove data binding reference
library/src/main/java/com/telefonica/mistica/header/HeaderView.kt	Removed data binding annotations and added wrapper methods with "header" prefix for attribute compatibility
library/src/main/java/com/telefonica/mistica/feedback/screen/README.md	Updated documentation to remove data binding reference
library/src/main/java/com/telefonica/mistica/feedback/error/README.md	Updated documentation to remove data binding reference
library/src/main/java/com/telefonica/mistica/feedback/error/LoadErrorFeedbackView.kt	Removed data binding annotations and unused import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T13:20:47Z

library/src/main/java/com/telefonica/mistica/feedback/error/LoadErrorFeedbackView.kt


    init {
        LayoutInflater.from(context).inflate(R.layout.load_error_feedback, this, true)
+        LayoutInflater.from(context).inflate(R.layout.load_error_feedback, this, true)


Duplicate layout inflation on line 27. The same layout is being inflated twice, which will create duplicate views in the hierarchy and cause incorrect UI rendering.

Suggested change

LayoutInflater.from(context).inflate(R.layout.load_error_feedback, this, true)

Applied change here: 85a6de1

Copilot · 2026-01-13T13:20:48Z

library/src/main/java/com/telefonica/mistica/header/HeaderView.kt

+    fun setHeaderFirstPretitle(@StringRes textRes: Int?) = setFirstPretitle(textRes)
+    fun setHeaderTitle(text: CharSequence?) = setTitle(text)
+
+    fun setHeaderInverse(value: Boolean) = setInverse(value)
+    fun setHeaderHasTopPadding(value: Boolean) = setHasTopPadding(value)
+
+    fun setHeaderFirstPretitle(text: CharSequence?) = setFirstPretitle(text)


Duplicate method definition for setHeaderFirstPretitle. Line 238 accepts @stringres Int? while line 244 accepts CharSequence?. This creates a naming collision that will cause compilation errors.

Currently these methods do not launch any compilation errors due to signature is different.

Copilot · 2026-01-13T13:20:48Z

library/src/main/java/com/telefonica/mistica/header/HeaderView.kt

+    fun setHeaderSubtitleHasSecondaryColor(value: Boolean) = setSubtitleHasSecondaryColor(value)
+
+    fun setHeaderActionButtonText(text: CharSequence?) = setActionButtonText(text)
+    fun setHeaderSecondaryActionButtonText(text: CharSequence?) = setSecondaryActionButtonText(text)


Line exceeds 120 characters. Consider breaking this line for better readability.

Suggested change

fun setHeaderSecondaryActionButtonText(text: CharSequence?) = setSecondaryActionButtonText(text)

fun setHeaderSecondaryActionButtonText(text: CharSequence?) =

setSecondaryActionButtonText(text)

Copilot · 2026-01-13T13:20:49Z

library/src/main/java/com/telefonica/mistica/input/README.md

 * Drop Down Input --> `com.telefonica.mistica.input.DropDownInput`

-All them can be placed directly on any layout, and can be configured with the following attributes (**All atributes for all types support databinding**):
+All them can be placed directly on any layout, and can be configured with the following attributes (**All attributes are supported for all types**):


Corrected grammar from 'All them' to 'All of them'.

Suggested change

All them can be placed directly on any layout, and can be configured with the following attributes (**All attributes are supported for all types**):

All of them can be placed directly on any layout, and can be configured with the following attributes (**All attributes are supported for all types**):

Applied change here: 1014011

Copilot · 2026-01-13T13:20:49Z

library/src/main/java/com/telefonica/mistica/input/CheckBoxInput.kt

+    fun setInputError(@StringRes errorRes: Int?) {
+        if (errorRes == null) {
+            error = null
+            setErrorEnabled(false)
+        } else {
+            error = context.getString(errorRes)
+            setErrorEnabled(true)
+        }
+    }


This is a potential breaking change. The new public method setInputError(@stringres Int?) was introduced as a replacement for the removed data binding attribute 'inputError'. While this maintains functional compatibility through attribute-based configuration, consumers who were directly calling methods on CheckBoxInput instances may need to update their code if they were using the data binding setError method signature that accepted CharSequence. Please apply the 'Breaking change' label to this PR. Migration notes should be added when drafting the release.

After merging all this feature branch in Mistica, is necessary to fit current implementation in "android-messenger" incresing new Mistica version.

Copilot · 2026-01-13T13:20:49Z

library/src/main/java/com/telefonica/mistica/input/CheckBoxInput.kt

+    fun setInputCheckText(text: CharSequence?) {
+        setText(text)
+    }
+
+    fun getInputCheckText(): CharSequence? {
+        return getText()
+    }


These are potential breaking changes. The new public methods setInputCheckText and getInputCheckText replace the removed data binding methods setText and getText. While these maintain functional compatibility through attribute-based configuration, the change in method naming may affect consumers who were calling these methods directly. Please apply the 'Breaking change' label to this PR. Migration notes should be added when drafting the release.

Same like previous one

github-actions · 2026-01-13T16:00:29Z

[Firebase] 📱 New catalog for testing generated:
Download from Firebase
Download from App Tester

haynlo

LGTM!

dhonti-axpe added 5 commits January 4, 2026 20:21

ANDROID-16934/pr2-remove-databinding: Remove databinding method from …

b526100

…"LoadErrorFeedabackView" component and update corresponding README file.

ANDROID-16934/pr2-remove-databinding: Update README file from "feedba…

50a33f0

…ck/screen" component

ANDROID-16934/pr2-remove-databinding: Remove databinding methods from…

ccd6fad

… "HeaderView" component and update corresponding README file

ANDROID-16934/pr2-remove-databinding: Remove databinding methods from…

2ea4064

… "HighlightedCardView" component and update its corresponding README file.

ANDROID-16934/pr2-remove-databinding: Remove databinding methods from…

33ca40d

… "Input", "TextInput" and expose some attributes also from "CheckBoxInput" components, updating their corresponding README files

dhonti-axpe changed the title ~~Android 16934/pr2 remove databinding~~ ANDROID-16934 -- (II) Remove databinding related code Jan 4, 2026

ANDROID-16934/pr2-remove-databinding: Remove unused imports from "Tex…

3304cc5

…tInput" component

This was referenced Jan 13, 2026

ANDROID-16934 -- (I) Remove databinding related code #478

Merged

ANDROID-16934 -- (III) Remove databinding related code #480

Merged

dhonti-axpe requested review from a team, bravoborja and haynlo and removed request for a team January 13, 2026 12:26

dhonti-axpe marked this pull request as ready for review January 13, 2026 12:26

haynlo requested a review from Copilot January 13, 2026 13:20

Copilot AI reviewed Jan 13, 2026

View reviewed changes

dhonti-axpe added 2 commits January 13, 2026 16:50

ANDROID-16934/pr2-remove-databinding: Remove duplicate line

85a6de1

ANDROID-16934/pr2-remove-databinding: Fix grammar in README file

1014011

haynlo approved these changes Jan 14, 2026

View reviewed changes

bravoborja approved these changes Jan 14, 2026

View reviewed changes

dhonti-axpe merged commit 25e476d into ANDROID-16934/base-remove-databinding Jan 14, 2026
4 checks passed

dhonti-axpe deleted the ANDROID-16934/pr2-remove-databinding branch January 14, 2026 14:43

	fun setHeaderSecondaryActionButtonText(text: CharSequence?) = setSecondaryActionButtonText(text)
	fun setHeaderSecondaryActionButtonText(text: CharSequence?) =
	setSecondaryActionButtonText(text)

	All them can be placed directly on any layout, and can be configured with the following attributes (All attributes are supported for all types):
	All of them can be placed directly on any layout, and can be configured with the following attributes (All attributes are supported for all types):

ANDROID-16934 -- (II) Remove databinding related code #479

ANDROID-16934 -- (II) Remove databinding related code #479

Uh oh!

Conversation

dhonti-axpe commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Jira ticket

🥅 What's the goal?

🚧 How do we do it?

☑️ Checks

🧪 How can I test this?

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

dhonti-axpe Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

dhonti-axpe Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

dhonti-axpe Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

dhonti-axpe Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

dhonti-axpe Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

haynlo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dhonti-axpe commented Jan 4, 2026 •

edited

Loading